ci: harden clang-tidy ratchet coverage - #1124
Merged
Merged
Conversation
justinjoy
added a commit
that referenced
this pull request
Aug 18, 2026
CLAUDE.md said "58 files today" and "The 13 files that are not clean yet"; tests/meson.build and clang-tidy-supported-majors.txt carried the same 13. Every one of them became wrong the moment a file was promoted, and this branch promotes three at once, so no per-branch number could have been correct. Delete the counts rather than decrement them. clang-tidy-backlog.txt's own header already argues the point for diagnostic counts -- "NO DIAGNOSTIC COUNTS. A count would look like useful precision and is not" -- and the same reasoning applies to file counts, which move on every promotion. ci-pr.yml already derives both sizes at runtime. scripts/ci/check-clang-tidy-ratchet.py carries the same stale sentence at :33 and is deliberately left alone: PR #1124 is rewriting that file, and a one-line comment edit there would conflict for no gain. Refs #1074, #1082, #1083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1122
Strengthens the clang-tidy ratchet against false-clean coverage regressions:
--dump-configvalues, including header filtersValidation: