ScipyOptimizer#794
Open
j-wilson wants to merge 1 commit into
Open
Conversation
Author
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs:
Resolves #793
Summary
This PR introduces a
ScipyOptimizerclass for GPFlow Modules that automatically extracts parameter bounds and passes them togpflow.optimizers.Scipy. This fixes an issue whereunconstrained_variablesthat are actually constrained under the prior cause model fitting to fail.Additionally, this PR fixes a bug in
resample_hyperparameterswhereprior_onwas ignored.Fully backwards compatible: no
There are edge-cases which may cause this code to fail. For example,
Scipymay choose to filter out parameters that it deems inactive and, in so doing, cause the provided bounds to be misspecified (since it does not filter out the corresponding bounds).PR checklist