Investigate adding acquisition metadata#766
Draft
uri-granta wants to merge 10 commits into
Draft
Conversation
added 10 commits
July 11, 2023 14:52
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue(s)/PRs:
Summary
Investigate adding acquisition metadata to rules, acquisition function builders and the ask tell interface (and possibly elsewhere). This can be used to make acquisition function updates depend on more than just the models and data.
There are at least four approaches here:
Since we don't currently have a convincing use case, my vote goes to 4. If we find one then we could consider 1, while perhaps holding off breaking the API until we're ready to do a 2.0 release for other reasons.
Fully backwards compatible: depends
PR checklist