#1681 Respect logfile option - #6379
Open
akleshchev wants to merge 2 commits into
Open
akleshchev wants to merge 2 commits into
akleshchev wants to merge 2 commits into
Conversation
This solution does not read UserLogFile as it isn't set yet and this is not the place to parse os-specific command line. This reverts commit 72f73ff.
akleshchev
force-pushed
the
andreyk/viewer_1681
branch
from
September 26, 2026 07:45
92f9e38 to
8c971f2
Compare
akleshchev
requested review from
maxim-productengine
and
a lite review from Copilot
September 26, 2026 07:45
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two moderate issues remain regarding per-instance log isolation and crash diagnostics.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates startup logging so the loaded UserLogFile setting is applied after configuration initialization.
Changes:
- Adjusts logfile initialization and rotation.
- Removes early platform-specific logfile parsing.
- Applies the configured logfile after settings load.
| File | Summary |
|---|---|
indra/newview/llappviewer.cpp |
Applies the configured logfile, but requires fixes for second-instance isolation and crash-log metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| // Command line could have updated UserLogFile | ||
| std::string log_filename = gSavedSettings.getString("UserLogFile"); | ||
| if (!log_filename.empty() && LLError::logFileName() != log_filename) |
maxim-productengine
approved these changes
Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts previous, incomplete and arguably wrong solution.
Applies UserLogFile once it is loaded.