#1681 Fix missed mac os logfile parsing - #6378
Closed
akleshchev wants to merge 1 commit into
Closed
akleshchev wants to merge 1 commit into
akleshchev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Correct the repeated “maping” typo before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR fixes missed macOS logfile parsing by adding shared command-line logfile scanning and non-Windows fallback handling.
Changes:
- Extracts reusable logfile argument parsing.
- Adds macOS/Linux fallback scanning.
- Updates
UserLogFilewhen a logfile argument is found.
| File | Summary |
|---|---|
indra/newview/llappviewer.cpp |
Implements cross-platform logfile scanning. Correct the repeated “maping” typo at lines 2633, 2659, and 2665. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_1681
branch
from
September 25, 2026 22:22
f337621 to
31361d4
Compare
akleshchev
force-pushed
the
andreyk/viewer_1681
branch
from
September 25, 2026 22:25
31361d4 to
70a3e08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing logic is misplaced, parsing command line is not llappviewer's job, but for now completing it to do the same for macos.