#6258 Switch legacy signal() with sigaction() - #6372
akleshchev wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The process-wide SIGPIPE disposition can overwrite the application's crash handler.
Review effort: Lite
Findings: None
What changed in this PR
This pull request replaces legacy signal() handling with sigaction() for SIGPIPE during process launches.
Changes:
- Configures
SIGPIPEhandling withsigaction(). - Preserves existing process-launch behavior.
| File | Summary |
|---|---|
indra/llcommon/llprocess.cpp |
Replaces signal() with sigaction(), but still changes the process-wide SIGPIPE disposition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
c744802 to
fd30a89
Compare
bc4c250 to
1151754
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One-time initialization can leave SIGPIPE assigned to the crash handler on later launches.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
Resolved since last review (2)
1151754 to
1fe5379
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: akleshchev <117672381+akleshchev@users.noreply.github.com>
|
I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |


Swap signal() with sigaction()
Due to a reported crash that wasn't reported to bugsplat, logs: