#2559 Fix emojis breaking tooltips - #6317
Open
akleshchev wants to merge 1 commit into
Open
akleshchev wants to merge 1 commit into
akleshchev wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes emoji handling in text links and restores underline color after emoji rendering.
Changes:
- Adds link-aware emoji segmentation.
- Restores underline rendering color.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Review summary |
|---|---|
indra/llui/lltextbase.cpp |
Existing editable URLs can still split when typing an emoji. |
indra/llrender/llfontgl.cpp |
Underline color is restored; comment contains a typo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
akleshchev
force-pushed
the
andreyk/viewer_2559_2
branch
2 times, most recently
from
September 14, 2026 22:10
527afbc to
0b059c5
Compare
akleshchev
force-pushed
the
andreyk/viewer_2559_2
branch
from
September 14, 2026 22:37
0b059c5 to
24a6a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emoji was splitting url in two and causing underlining text to render white.