On name change notify the plugin to update. - #6305
Merged
Merged
Conversation
Rider-Linden
requested review from
akleshchev and
marchcat
and
a lite review from Copilot
September 11, 2026 17:00
Contributor
There was a problem hiding this comment.
Pull request overview
Updates object property synchronization so external plugins receive name and description changes even when objects are deselected.
Changes:
- Forwards property replies for unselected objects.
- Requests refreshed properties after plugin-originated modifications.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Summary |
|---|---|
indra/newview/llselectmgr.cpp |
Notifies the plugin of property updates regardless of selection state. |
indra/newview/llscripteditorws.cpp |
Requests updated properties after object modifications. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| LLScriptEditorWSServer::ptr_t ws_server = LLScriptEditorWSServer::getServer(); | ||
| if (ws_server) | ||
| { | ||
| ws_server->onObjectPropertyChanged(id, name, desc, inv_serial); |
| } | ||
|
|
||
| // Force a properties reply so the editor sees the change without an in-world selection. | ||
| LLSelectMgr::instance().requestObjectPropertiesFamily(prim); |
marchcat
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Viewer was not notifying the plugin about a successful name change on the object.
On an object property change, explicitly request the update and forward to the plugin if the server is active.
Issue #6304