CreateLandmarkForPosition floater fails to save descriptions that contain newline

[maestrolinden]

Environment

Second Life Test 7.1.12.12197486645 (64bit)
Release Notes

You are at 89.5, 239.5, 23.0 in MTester Playground located at simhost-09983eca7f9119b3f.aditi
SLURL: secondlife://Aditi/secondlife/MTester%20Playground/90/239/23
(global coordinates 601.5, 751.5, 23.0)
HIVE 2025-01-10.12717167991
Release Notes

CPU: Apple M1 Pro (2400 MHz)
Memory: 16384 MB
OS Version: macOS 15.2.0 Darwin 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 19:01:59 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6000 x86_64
Graphics Card Vendor: Apple
Graphics Card: Apple M1 Pro

OpenGL Version: 4.1 Metal - 89.3

Window size: 1224x776
Font Size Adjustment: 96pt
UI Scaling: 0.8
Draw distance: 96m
Bandwidth: 10000kbit/s
LOD factor: 1.125
Render quality: 1
Texture memory: 10922MB
Disk cache: Max size 1638.4 MB (100.0% used)
HiDPI display mode:

RestrainedLove API: (disabled)
J2C Decoder Version: KDU v8.4.1
Audio Driver Version: OpenAL, version 1.1 ALSOFT 1.23.1 / OpenAL Community / OpenAL Soft: OpenAL Soft
Dullahan: 1.14.0.202408091638
CEF: 118.4.1+g3dd6078+chromium-118.0.5993.54
Chromium: 118.0.5993.54
LibVLC Version: 3.0.21
Voice Server Version: Vivox 4.10.0000.32327.5fc3fe7c.5942f08

Packets Lost: 0/1970 (0.0%)
January 16 2025 14:11:13

Description

The viewer that supports the new #3217 location-specified landmark creation feature allows the user to specify a description for the new landmark in textbox labeled 'My Notes'. The description text appears properly when the text is a single line, but is dropped in the created landmark when the description contains multiple lines.

The viewer otherwise prevents the user from entering newlines into inventory item descriptions, so I believe the new dialog should prevent newline entry in the 'My Notes' textbox as well.

Reproduction steps

1. Visit a region that supports the CreateLandmarkForPosition capability (such as the one in my report's environment field)
2. Enter a valid SLURL (e.g. secondlife://Aditi/secondlife/Bonifacio/109/240/23 ) into chat and click 'Send'
3. In the Conversations floater, right-click on the SLURL that you just sent and select "Create Landmark for SLURL" from the context menu
4. In the 'Landmark Added' floater, attempt to add multiple lines of text under 'My Notes', and click 'OK' to save
5. View the properties of the new landmark in the Inventory floater, and note whether the description set in step (4) was saved

Expected results:

• In step (4), it should be impossible to add a newline character to the landmark description. The viewer should probably throw the same error that appears when editing the properties of an inventory item, which indicates that an invalid keystroke entered.
• The description the user enters should appear in the new inventory item.

Actual results:

• In step (4), the user is able to enter multiple lines for the description, though unicode is generally blocked:

- In step (5), the description data is lost - it appears empty in the inventory item's description

[kurtlinden]

Passed QA

Second Life Release 26.4.0.34502396632