Remove all deprecated functionality - #2951
Open
amontanez24 wants to merge 9 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2.0.0 #2951 +/- ##
==========================================
- Coverage 98.06% 98.04% -0.03%
==========================================
Files 74 72 -2
Lines 8582 8420 -162
==========================================
- Hits 8416 8255 -161
+ Misses 166 165 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
amontanez24
marked this pull request as ready for review
August 18, 2026 21:38
amontanez24
requested review from
frances-h,
rwedge and
sarahmish
and removed request for
a team
August 18, 2026 21:38
sarahmish
reviewed
Aug 19, 2026
sarahmish
left a comment
sarahmish
left a comment
Contributor
There was a problem hiding this comment.
There are other functions that are raising future warnings, should they be removed?
SDV/sdv/metadata/multi_table.py
Lines 1208 to 1223 in 325f32b
Comment on lines
161
to
164
Contributor
There was a problem hiding this comment.
should this be removed since cuda is deprecated? The same would apply for copulagan
sarahmish
approved these changes
Aug 20, 2026
| assert synthetic_data_2.columns.tolist() == data_columns | ||
| assert synthetic_data_3.columns.tolist() == data_columns | ||
| assert len(synthetic_data_1) == 10 | ||
| assert len(synthetic_data_2) == len(synthetic_data_3) == 10 |
Contributor
There was a problem hiding this comment.
I think len(synthetic_data_2) should be kept
assert len(synthetic_data_2) == 10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2948
This PR doesn't remove the deprecated constraints or metadata. That will be done in separate issues