Repository navigation
Deliver the shaded ivy.xml only where Ivy publishes - #147
Conversation
project-matrix-shading expected shading a Scala.js row to fail on every sbt 2, since the platform was not part of the CrossVersion. From sbt 2.0.7 (sbt/sbt#9621) and 2.1 (sbt/sbt#9620) it is, so the row shades, and the test failed there. Now the test expects the failure only before 2.0.7. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
sbt 2.1 has no Ivy publishing of its own: deliverLocal says an Ivy-based plugin is needed and ivyModule is unit. Loading IvyRepublish also stopped the plugin loading at all on sbt 2.1, which removed Ivy from the plugin classpath. Now the plugin republishes only where IvyRepublish loads. Elsewhere, as on sbt 2.1, it rewrites the ivy.xml that publishLocal wrote, and its checksums, and CI runs the sbt 2 scripted tests on sbt 2.1 too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
@alexarchambault @tgodzik tried updating sbt in scalameta to 2.1.0-RC1 (which dropped explicit ivy support), and this is what claude proposed as a fix. |
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Not an expert here, but the PR seems to make sense. @alexarchambault any opinion?
|
@tgodzik thank you. any thought on releasing? |
|
Let's see if it works https://github.com/coursier/sbt-shading/actions/runs/41475339364 I know @alexarchambault was changing things around publishing |
|
Looks like we can publish here anymore, looks more complicated. @alexarchambault how can we release this? Or should we fork the repo under scalameta? |
|
@tgodzik Feel free to fork it and publish it from another org. I don't use it anymore in my projects, and I'd rather let others maintain it and publish it. |
@tgodzik who can help with bringing it into the scalameta umbrella and setting up publishing/secrets/etc? sbt 2.0.x has some issues which 2.1.x presumably fixes, so this release will come in handy. |
|
We discussed it and I think we can bring it to sbt org. @alexarchambault it's probably easiest to transfer the repo to a different org, would you be able to do that? |
Meaning sbt obviously. I will take care of everything there. |
|
@tgodzik I don't have the rights to create a repository in the sbt org (needed to transfer the repo there apparently), but I gave you admin rights to the repo here, so that you can proceed |
sbt 2.1 has no Ivy publishing of its own: deliverLocal says an Ivy-based plugin is needed and ivyModule is unit. Loading IvyRepublish also stopped the plugin loading at all on sbt 2.1, which removed Ivy from the plugin classpath.
Now the plugin republishes only where IvyRepublish loads. Elsewhere, as on sbt 2.1, it rewrites the ivy.xml that publishLocal wrote, and its checksums, and CI runs the sbt 2 scripted tests on sbt 2.1 too.