Added support for Longruner Stepper Motor#22
Open
neel-kumar wants to merge 10 commits into
Open
Conversation
MFoster
reviewed
May 25, 2020
|
|
||
| m1 = PiMotor.Stepper("STEPPER1") | ||
| m1.setSequence([ | ||
| [1,0,0,0], |
Contributor
There was a problem hiding this comment.
I like the idea of setting a sequence but I believe this sequence will create a jitter effect in a unipolar stepper. I believe the issue is you don't want to energize A1 and A2 simultaneously.
Author
There was a problem hiding this comment.
I bought the Longruner and got the sequence from http://www.4tronix.co.uk/arduino/Stepper-Motors.php . So far this sequence has worked with this motor for me. If I see a jitter affect then I would set the right sequence. Thanks for the feedback and the URL. Let me know if I need to do something else to merge the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored PiMotor to work with every stepper motor. Even with these changes the previous code will still work.
Please accept the change.