Repository navigation
fix(grants)!: require schema for bare ALL selectors - #1847
Merged
Shinigami92 merged 1 commit intoOct 28, 2026
Merged
Conversation
Creatixpy
added
breaking change
Shinigami92
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1779. Follow-up to the optional validation suggested in #1770.
This is a compatibility change: bare
tables: 'ALL'andsequences: 'ALL'now require the top-levelschemaoption. Grant/revoke operations and automatic reversal throw a descriptive error before generating SQL. The issue was labeleds: needs decisionwith no maintainer decision recorded when implementation began; please approve or adjust this approach during review.Explicit
{ name: 'ALL' }, schema-qualified objects namedALL, literal arrays (including['ALL', 'foo']), ordinary named selections and'ALL'withschemaretain their behavior. The existing named-table scope behavior is preserved.Updated the grants reference with examples and added a compatibility entry to
upgrading.md.Validation: