Implement registering and calling stop callback of resources - #740
Closed
lilioid wants to merge 1 commit into
Closed
Implement registering and calling stop callback of resources#740lilioid wants to merge 1 commit into
lilioid wants to merge 1 commit into
Conversation
Member
|
Thank you for this, I will incorporate these changes (sans the odd |
Contributor
Author
Ahh yeah that must have slipped through from when I was confused about OTP vs. NIF versions (hence the #739 ).
A safe wrapper is definitely the preferred way to go and whichever way you want to incorporate this works for me. This was just what I needed to get my things running 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented a new
stop()callback compatible with ErlNifResourceStop as an addition to theResourcetrait.This has been manually verified to work by implementing a small program on top of it.
The codegen for the
#[resource_impl]macro also just works.resolves #735