Add GameCube controller support via Serial Interface driver - #34
Open
JGM01 wants to merge 4 commits into
Open
Conversation
Add .zed to the list of ignored editor files.
JGM01
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for a standard GameCube controller by implementing the Serial Interface (SI) driver. I just thought that being able to take user input easier would be helpful for testing other future library features.
Specifically, I added:
serial_interface.rs: A serial-interface driver. Basically just wraps SI_COMM_REG and creates a SiChannel abstraction for handling individual controller ports.pad.rs: Controller snapshot-state-reading API. Maps 8-byte Joy-Bus payload into structured button and stick states.Also, I think that
pad.rswould be better in the future as a hub for a trait-based "JoyBusDevice" structure so other input devices can get added fairly easy. That's out-of-scope of this PR though (no one wants to review 1k+ lines) but is probably the thing I'd do next after/if this gets in.