Skip to content

Adapt to changed field names in crates.io CSV data - #118

Merged
Shnatsel merged 2 commits into
masterfrom
fix-csv
Oct 15, 2026
Merged

Shnatsel merged 2 commits into
masterfrom
fix-csv

Conversation

@Shnatsel

@Shnatsel Shnatsel commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Fixes #117

@smoelius smoelius left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for responding to this so quickly, @Shnatsel. I tested the changes locally and they fix the problem! 🎉

My questions below are mostly about understanding your software philosophy.

Comment thread src/crates_cache.rs Outdated
name: Option<String>,
}

// Keep the dump schema separate from the existing JSON cache format.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I ask why you want to keep them separate?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that the existing caches can be reused and do not throw errors. I don't want to write the code for migrations etc.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nvm, we can probably get away with an alias here

Comment thread src/crates_cache.rs Outdated
gh_avatar: Option<String>,
gh_id: Option<String>,
username: String,
name: Option<String>,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current CSV headers are:

created_at,gh_id,id,name,username

In particular:

@Shnatsel
Shnatsel merged commit a7d2abd into master Oct 15, 2026
3 checks passed
@Shnatsel
Shnatsel deleted the fix-csv branch October 15, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crates.io CSV header change causes cargo supply-chain update to fail

2 participants