Repository navigation
Conversation
smoelius
approved these changes
Oct 13, 2026
| name: Option<String>, | ||
| } | ||
|
|
||
| // Keep the dump schema separate from the existing JSON cache format. |
Collaborator
There was a problem hiding this comment.
Can I ask why you want to keep them separate?
Member
Author
There was a problem hiding this comment.
So that the existing caches can be reused and do not throw errors. I don't want to write the code for migrations etc.
Member
Author
There was a problem hiding this comment.
Ah nvm, we can probably get away with an alias here
| gh_avatar: Option<String>, | ||
| gh_id: Option<String>, | ||
| username: String, | ||
| name: Option<String>, |
Collaborator
There was a problem hiding this comment.
The current CSV headers are:
created_at,gh_id,id,name,username
In particular:
- The
gh_avatarfield was removed (by Stop writingusers.gh_avatarrust-lang/crates.io#13987 and Dropusers.gh_avatarcolumn rust-lang/crates.io#14013). Should it be removed here as well? - Should the
created_atfield be tracked? - Would it be useful to match the field order
crates.iouses?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117