Skip to content

linfa-lars: remove core::f64 import shadowing the f64 type in tests - #463

Open
whispem wants to merge 1 commit into
rust-ml:masterfrom
whispem:fix-lars-deprecated-epsilon
Open

whispem wants to merge 1 commit into
rust-ml:masterfrom
whispem:fix-lars-deprecated-epsilon

Conversation

@whispem

@whispem whispem commented Nov 17, 2026

Copy link
Copy Markdown

linfa-lars: remove core::f64 import shadowing the f64 type in tests

The test module imports core::f64, so f64::EPSILON resolves to the deprecated module constant core::f64::EPSILON instead of the associated constant on the f64 type.

Recent clippy rejects it, which fails codequality (stable).
Removing the import is enough: the three call sites then use f64::EPSILON on the type.

The 1.88.0 jobs still fail for an unrelated reason: uuid 1.29.2 requires rustc 1.89, as mentioned in #462.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 15:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@whispem

whispem commented Nov 17, 2026

Copy link
Copy Markdown
Author

CI note: the remaining failures are pre-existing on master.

cargo fmt --check fails on a comment in linfa-clustering/src/k_means/algorithm.rs with the current stable rustfmt, which also stops the job before clippy runs, and the 1.88.0 jobs fail on uuid requiring rustc 1.89.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants