Repository navigation
Rollup of 12 pull requests - #164757
Open
JonathanBrouwer wants to merge 30 commits into
Open
Rollup of 12 pull requests#164757JonathanBrouwer wants to merge 30 commits into
JonathanBrouwer wants to merge 30 commits into
Conversation
Let's link the relevant UI tests to the Reference's rules for unions.
and update plaform note get illumos sysroot from mirror
This module can contain various helpers for `object`, not strictly those that work with symbols.
Memory64 is merged into the spec since 2025-07-23 (WASM 3.0).
This will make it possible to remove the compiler's Hash impl for FileName.
A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change. This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib). This PR aims to unblock changes to `impl Hash for Path`, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.
Avoid stdlib's `impl Hash for Path` for stable hashing A subtle consequence of the stage0 redesign is that the compiler must take care to avoid relying on any stdlib-provided Hash impl when computing stable hashes, or at least any such impl that is actually liable to change. This was noticed when trying to strengthen the provided Hash impl for Path, which triggered baffling CI failures because the stable hashes produced by the stage1 compiler (built against stage0 stdlib) were inconsistent with the ones that would have been produced by the stage2 compiler (built against in-tree stdlib). This PR aims to unblock changes to `impl Hash for Path`, by making the compiler not rely on it for stable hashing. It does not attempt to solve the broader problem of the compiler relying on stdlib hash details.
update to illumos sysroot 20210501 Update the sysroot for illumos to this one: https://github.com/illumos/sysroot/releases/#release-20210501-e0b4275f34-v0 Closes rust-lang#150756
rmake: Add helpers for iterating symbols and objects We have a handful tests that do a common pattern of opening a file, looping through its symbols, and performing some validation on each one, which can be a bit inconvenient to do manually. The pattern at https://github.com/rust-lang/compiler-builtins/blob/f521807de24520770991263387ba8c06e462edf8/crates/symcheck/src/main.rs works rather well to make this easier, so add it at `rmake` and update one test that does symbol iteration.
…isDenton refactor Windows remove_dir_all It took me a bit to understand this code. I hope I understood it correctly now. r? @ChrisDenton
…hnTitor std: use `SOCK_NONBLOCK` in `connect_timeout` I doubt the performance improvement will be measurable, but using [`SOCK_NONBLOCK`](https://manned.org/man/socket) upon socket creation instead of manually setting the non-blocking mode seemed like a good idea to me. Implementing this required a consolidation of the `connect_timeout` logic, which seems like a good thing in its own right.
…Borrowck-rename, r=jdonszelmann Rename `PostTypeckUntilBorrowck` -> `PostTypeckThroughBorrowck` This was a rename suggested in the following [Zulip thread](https://rust-lang.zulipchat.com/#narrow/channel/618216-t-types.2Fcall-for-participation/topic/rename.20.60TypingMode.3A.3APostTypeckThroughBorrowck.60/with/624384207) r? jdonszelmann
…x, r=petrochenkov Declare `SyntaxContext` through `rustc_index::newtype_index!` `SyntaxContext` is basically an index type but it is not declared through `newtype_index`. r? @petrochenkov
Avoid cloning CFG-related analysis data. For perf. We can avoid cloning CFG-related data while mutating the body.
…ations_unions, r=PLeVasseur,traviscross Add reference annotations for unions Let's link the relevant UI tests to the Reference's rules for unions.
Allow `llm-assisted` label to be set without write access I.e. allow contributors to set https://github.com/rust-lang/rust/labels/llm-assisted via triagebot as well.
Remove docs mentioning instability of wasm64 Memory64 is merged into the spec, from my reading since 2025-07-23 (and included as part of WebAssembly 3.0). (It still isn't available in Safari and some other engines, but we shouldn't track that in our docs, see https://webassembly.org/features/ for that instead). r? compiler CC target maintainer @alexcrichton
Update LLVM PassBuilder constructor calls to pass a context LLVM's llvm/llvm-project#233150 made the PassBuilder constructor take a LLVMContext argument.
rustbot
added
A-CI
Member
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 22, 2026
Rollup of 12 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3
Contributor
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
impl Hash for Pathfor stable hashing #164458 (Avoid stdlib'simpl Hash for Pathfor stable hashing)SOCK_NONBLOCKinconnect_timeout#163983 (std: useSOCK_NONBLOCKinconnect_timeout)PostTypeckUntilBorrowck->PostTypeckThroughBorrowck#164307 (RenamePostTypeckUntilBorrowck->PostTypeckThroughBorrowck)SyntaxContextthroughrustc_index::newtype_index!#164425 (DeclareSyntaxContextthroughrustc_index::newtype_index!)llm-assistedlabel to be set without write access #164717 (Allowllm-assistedlabel to be set without write access)Failed merges:
record_*macros from the metadata encoder #164636 (Removerecord_*macros from the metadata encoder)r? @ghost
Create a similar rollup