Rollup of 13 pull requests by JonathanBrouwer · Pull Request #164634 · rust-lang/rust

JonathanBrouwer · 2026-10-20T12:59:35Z

Successful merges:

Add new RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags mode for testing stable compiler behavior in UI tests #163664 (Add new RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags mode for testing stable compiler behavior in UI tests)
[debuginfo] Emit usize and isize as typedefs #163104 ([debuginfo] Emit usize and isize as typedefs)
MIR move elimination [4/6]: MoveElimination #163338 (MIR move elimination [4/6]: MoveElimination)
add ReadDir::dir to get the directory handle of the underlying directory #163701 (add ReadDir::dir to get the directory handle of the underlying directory)
Don't try to skip anything in Skip::advance_by(0) #164488 (Don't try to skip anything in Skip::advance_by(0))
Don't ignore unknown LLVM diagnostics #164578 (Don't ignore unknown LLVM diagnostics)
Improve bit permutation codegen #164611 (Improve bit permutation codegen)
std: Combine is_powerpc64_feature_detected into is_powerpc_feature_detected #164612 (std: Combine is_powerpc64_feature_detected into is_powerpc_feature_detected)
document that ! does bitwise and logical negation #162668 (document that ! does bitwise and logical negation)
lint: suggest fXX::is_nan for unsuffixed NaN comparisons #164264 (lint: suggest fXX::is_nan for unsuffixed NaN comparisons)
layout invariant: turn delayed bug back into proper assertion #164509 (layout invariant: turn delayed bug back into proper assertion)
rustdoc: Correctly handle inner deprecated attribute on modules #164594 (rustdoc: Correctly handle inner deprecated attribute on modules)
arch::breakpoint: avoid confusing 'equivalent' terminology #164629 (arch::breakpoint: avoid confusing 'equivalent' terminology)

r? @ghost

Create a similar rollup

…tests

…I test

…a UI test

…mpiler-flags=<flags>`

If we try to eagerly process our skip count, we might see the end of the inner iterator. `Iterator::advance_by` is supposed to return a non-zero `Err` count when exhausted, but there's no room for `Skip` to report anything in this case. So, it's better that we don't even try.

Rust currently ignores LLVM diagnostic kinds that it does not know about. This means that we sometimes ignore error diagnostics, which can then result in silent miscompiles. This exposes `LLVMGetDiagInfoSeverity` returning `DiagnosticSeverity`, renamed from `DiagnosticLevel` to match LLVM terminology. Custom code to fetch the diagnostic severity for inline asm diagnostics can then be dropped. For unknown diagnostics, we emit a warning/error depending on severity. Notes and remarks continue to be ignored. One oddity I ran into along the way is that the linker diagnostic has severity error, but we only report a warning. I've kept this for now as we still error down the line and this ends up providing a bit more information (which file the duplicate symbol originates from).

…Only` and fix docs

Merge the PGO, Unsupported into UnknownDiagnostic and rename it to Other. We don't do anything special for them, so there is no need to represent them differently.

JonathanBrouwer · 2026-10-20T12:59:49Z

@bors r+ p=5 force

rust-bors · 2026-10-20T12:59:52Z

📌 Commit c3425f8 has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 13 pull requests Successful merges: - #163664 (Add new `RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags` mode for testing stable compiler behavior in UI tests) - #163104 ([debuginfo] Emit `usize` and `isize` as typedefs) - #163338 (MIR move elimination [4/6]: MoveElimination) - #163701 (add ReadDir::dir to get the directory handle of the underlying directory) - #164488 (Don't try to skip anything in `Skip::advance_by(0)`) - #164578 (Don't ignore unknown LLVM diagnostics) - #164611 (Improve bit permutation codegen) - #164612 (std: Combine `is_powerpc64_feature_detected` into `is_powerpc_feature_detected`) - #162668 (document that `!` does bitwise and logical negation) - #164264 (lint: suggest `fXX::is_nan` for unsuffixed NaN comparisons) - #164509 (layout invariant: turn delayed bug back into proper assertion) - #164594 (rustdoc: Correctly handle inner `deprecated` attribute on modules) - #164629 (arch::breakpoint: avoid confusing 'equivalent' terminology)

rust-bors · 2026-10-20T13:07:42Z

💔 Test for 5675c3e failed: CI. Failed job:

auto - test-x86_64-gnu-parallel-frontend (web logs, enhanced plaintext logs)

JonathanBrouwer · 2026-10-20T13:08:02Z

@bors retry

…uwer Rollup of 13 pull requests Successful merges: - #163664 (Add new `RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags` mode for testing stable compiler behavior in UI tests) - #163104 ([debuginfo] Emit `usize` and `isize` as typedefs) - #163338 (MIR move elimination [4/6]: MoveElimination) - #163701 (add ReadDir::dir to get the directory handle of the underlying directory) - #164488 (Don't try to skip anything in `Skip::advance_by(0)`) - #164578 (Don't ignore unknown LLVM diagnostics) - #164611 (Improve bit permutation codegen) - #164612 (std: Combine `is_powerpc64_feature_detected` into `is_powerpc_feature_detected`) - #162668 (document that `!` does bitwise and logical negation) - #164264 (lint: suggest `fXX::is_nan` for unsuffixed NaN comparisons) - #164509 (layout invariant: turn delayed bug back into proper assertion) - #164594 (rustdoc: Correctly handle inner `deprecated` attribute on modules) - #164629 (arch::breakpoint: avoid confusing 'equivalent' terminology)

rust-log-analyzer · 2026-10-20T13:36:24Z

The job test-x86_64-gnu-parallel-frontend failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

Important

For more information how to resolve CI failures of this job, visit this link.

rust-bors · 2026-10-20T14:26:48Z

💔 Test for 184f14d failed: CI. Failed job:

auto - test-x86_64-gnu-nopt (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-10-20T14:28:46Z

The job test-x86_64-gnu-nopt failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


failures:

---- [ui] tests/ui/codegen/huge-stacks.rs#unoptimized stdout ----
Saved the actual stderr to `/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/codegen/huge-stacks.unoptimized/huge-stacks.unoptimized.stderr`
normalized stderr:
warning: <unknown>:0:0: stack frame size (4294967320) exceeds limit (4294967295) in function '_RNvCsCRATE_HASH_11huge_stacks4func'

warning: 1 warning emitted




The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args codegen/huge-stacks.rs`

error in revision `unoptimized`: 1 errors occurred comparing output.
status: exit status: 0
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/codegen/huge-stacks.rs" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--cfg" "unoptimized" "--check-cfg" "cfg(test,FALSE,unoptimized,optimized)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/codegen/huge-stacks.unoptimized/a" "-Znext-solver=coherence" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2015"
stdout: none
--- stderr -------------------------------
warning: <unknown>:0:0: stack frame size (4294967320) exceeds limit (4294967295) in function '_RNvCs1ZC8vK8RYBa_11huge_stacks4func'

warning: 1 warning emitted
------------------------------------------

---- [ui] tests/ui/codegen/huge-stacks.rs#unoptimized stdout end ----

rust-bors · 2026-10-20T14:33:17Z

PR #164578, which is a member of this rollup, was unapproved.

evan-dickinson and others added 30 commits September 11, 2026 16:09

document that ! does bitwise and logical negation

acd02b8

Add RUSTC_BOOTSTRAP=-2 as a way of simulating a stable rustc in UI …

8240628

…tests

Implement act-as-stable compiletest directive

94a6b12

Use act-as-stable in the feature-gate-autodiff-use test

522200b

Migrate const-destruct-stable-toolchain from a run-make test to a U…

aa97b1b

…I test

Migrate print-request-help-stable-unstable from a run-make test to …

0c3b3be

…a UI test

lint: suggest fXX::is_nan for unsuffixed NaN comparisons

6fc1dc1

lint: use UFCS for NaN comparison suggestions

4f9916a

lint: preserve qualified paths in NaN suggestions

ed4718f

lint: fix NaN suggestions for nested operands and macros

62cf356

Replace RUSTC_BOOTSTRAP=-2 with `RUSTC_BOOTSTRAP=-allow-unstable-co…

f6c3d62

…mpiler-flags=<flags>`

Use RUSTC_BOOTSTRAP=-allow-unstable-compiler-flags in compiletest

adbf2a5

layout invariant: turn delayed bug back into proper assertion

20a7d95

test: re-organize ui test case

2c2a5e9

test: cover shadowing in qualified NaN suggestions

d201932

lint: skip NaN diagnostics for custom comparisons

3b9350a

Rename the unstable compiler flag mode to `AllowUnstableCompilerFlags…

8aa94f1

…Only` and fix docs

Update Cranelift test script

61ab2cd

Remove incorrect comments about Rvalue::Aggregate not being allowed

46b6207

Add MIR move elimination pass

0a266ba

Correctly handle inner deprecated attribute on modules

e39618c

Improve bit permutation codegen

8735b14

add ReadDir::dir to get the directory handle of the underlying directory

37bc46f

miri: use and test new ReadDir::dir support

730a53d

Don't distinguish diagnostic kinds without special treatment

fcc7978

Merge the PGO, Unsupported into UnknownDiagnostic and rename it to Other. We don't do anything special for them, so there is no need to represent them differently.

Don't downgrade linker error to warning

b95ad06

Also allow -Zunstable-options in act-as-stable

cccc5be

emit usize and isize as typedefs

0370417

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 20, 2026

JonathanBrouwer mentioned this pull request Oct 20, 2026

Don't ignore unknown LLVM diagnostics #164578

Open

JonathanBrouwer closed this Oct 20, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 20, 2026

Navigation Menu

Repository navigation

Rollup of 13 pull requests - #164634

Rollup of 13 pull requests#164634
JonathanBrouwer wants to merge 46 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-FCpgkpi

JonathanBrouwer commented Oct 20, 2026

Uh oh!

JonathanBrouwer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 20, 2026

Uh oh!

JonathanBrouwer commented Oct 20, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

rust-log-analyzer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Conversation

JonathanBrouwer commented Oct 20, 2026

Uh oh!

JonathanBrouwer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Oct 20, 2026

Uh oh!

JonathanBrouwer commented Oct 20, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

rust-log-analyzer commented Oct 20, 2026

Uh oh!

rust-bors Bot commented Oct 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants