add environ to unix - #5339
Conversation
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
|
3bb2917 to
ea35ffa
Compare
|
environ now linux-gnu only. glibc declares it in <unistd.h> behind _GNU_SOURCE. no ctest skips elsewhere. commit messages link to headers. |
ea35ffa to
edd0b34
Compare
|
@rustbot ready |
This comment has been minimized.
This comment has been minimized.
|
9904a3b to
c98e663
Compare
c98e663 to
ae85f0a
Compare
This comment has been minimized.
This comment has been minimized.
ae85f0a to
2675498
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
May as well take this but please clean up the history - 15 commits is a lot for a four line diff :)
@rustbot author
6d89228 to
4dbb2f5
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
`environ` is an array of pointers to the environment strings, declared in <unistd.h> behind _GNU_SOURCE on glibc. Ref: https://man7.org/linux/man-pages/man7/environ.7.html
4dbb2f5 to
5c2e1fe
Compare
|
Please always include a link to headers in the commit message, the manpage is fine too but it's the headers we check against. I've already seen https://github.com/sailfishos-mirror/glibc/blob/4a07bb292f921c10e71fbf48c4a7f44391feb06c/posix/unistd.h#L566 though so this is okay. |




see commit messages.
libc-test/semver/unix.txtupdatedcargo test -p libc-test— 15 passedCloses #2520
@rustbot label +stable-nominated