fix(deps): update minimal-versions for wasi - #1899
Conversation
e74136f to
38143d7
Compare
c5b3a1f to
77dd791
Compare
77dd791 to
0b5fb23
Compare
|
@taiki-e Is there currently a better way to do this using |
|
The correct approach is to call cargo-minimal-versions multiple times. Instead of simply calling |
| - uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2 | ||
| - run: cargo minimal-versions check --workspace --all-targets --feature-powerset --ignore-private | ||
| - run: RUSTC_BOOTSTRAP=1 cargo -Zminimal-versions generate-lockfile | ||
| - run: cargo hack check --locked --workspace --all-targets --feature-powerset --ignore-private --target aarch64-apple-darwin |
There was a problem hiding this comment.
--all-targets is usually a bad idea here since it enables dev-deps. This often hides compile errors that exist in lib/bin which will be released on crates.io. See also the quoted comment in https://github.com/taiki-e/cargo-minimal-versions#details.
There was a problem hiding this comment.
Is --no-dev-deps necessary with cargo-minimal-versions?
There was a problem hiding this comment.
cargo-minimal-versions automatically do the same processing as --no-dev-deps when --all-targets/--tests/etc. are not used.
|
@taiki-e Is there a way to run |
|
Does multi-target (taiki-e/cargo-hack#167) not work? |
I didn't know about Cargo's multi-target builds! Since that feature was implemented in 1.64, we should be good to use it with our MSRV of 1.65. |
Btw, cargo-hack (used inside cargo-minimal-versions) emulates multi-target builds on pre-1.64 Rust (taiki-e/cargo-hack#168). |
Fix minimal version requirements for wasi and add a check to CI.
This also refactors the MSRV workflow configuration in CI by avoiding a matrix build, reducing GitHub Actions cache usage.