Repository navigation
Conversation
Recognize a leading rustup +toolchain selector before clap parsing and propagate it via RUSTUP_TOOLCHAIN to rustc probes and child Cargo commands. This keeps direct cargo-zigbuild +nightly build on the Zig-aware build path instead of delegating to raw Cargo without Zig linker configuration. Add regression coverage for dispatch, environment propagation, and existing plugin / external commands. Fixes rust-cross#512. Signed-off-by: 1998LJ <wenjinjia4@gmail.com>
Keep new PR documentation changes in distinct README sections to reduce future merge conflicts with the separate target-mappings PR. Signed-off-by: 1998LJ <wenjinjia4@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #512.
cargo-zigbuild +nightly build --target ...(and other+toolchainselectors) as a Zig-aware build, instead of treating+nightlyas an external command and delegating directly to Cargo without Zig linker configuration.RUSTUP_TOOLCHAINbefore rustc-version probes and child Cargo command execution so the selected toolchain is consistent throughout the build.cargo +nightly zigbuildplugin path and generic external Cargo subcommands.Verification
cargo test --locked: passed (library, CLI and integration tests).cargo fmt --all -- --check: passed.cargo clippy --all-targets --all-features --locked -- -D warnings -A clippy::useless_conversion -A clippy::useless_borrows_in_formatting -A clippy::chunks_exact_to_as_chunks: passed (these three lint groups are triggered by pre-existing code under Rust 1.99).+stableinvocation without needing Zig or a cross-compiler. The original Windows GNU getrandom compilation with nightly/Zig was not run locally.The implementation and tests were prepared with AI coding assistance and verified locally.
Signed-off-by: 1998LJ wenjinjia4@gmail.com