Repository navigation
refactor: Effect best practices and comprehensive tests - #11
Merged
Merged
Conversation
Migrate all error types to Data.TaggedError, wrap external library calls (quill-delta-to-html, turndown) in Effect.try for proper error handling, and make deltaToMarkdown/contentToMarkdown return Effect values. Add 36 new tests covering edge cases including null content, empty deltas, network errors, GraphQL errors, and missing data fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfigError,InvalidPostIdError,SlabApiError,SlabNetworkError,DeltaConversionError) toData.TaggedErrorwith single-object constructorsquill-delta-to-html,turndown) inEffect.tryfor proper error boundary handlingdeltaToMarkdownandcontentToMarkdownreturnEffectvalues, propagating errors through the Effect pipelinetransformPosteffectful, with all callers properly yielding resultsTests
test/config.test.ts,test/deltaToMarkdown.test.ts