Skip to content

fix(kubernetes): preserve proxy URL for exec sessions #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
russellb merged 1 commit into from
Sep 2, 2026
Merged

fix(kubernetes): preserve proxy URL for exec sessions #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions crates/openshell-driver-kubernetes/src/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4734,6 +4734,9 @@ fn apply_supervisor_proxy_pod_topology(
// proxy variables; the supervisor's own gateway dial is a direct
// gRPC channel that does not consult them.
let proxy_url = proxy_pod_proxy_url(&service_dns);
// The process supervisor clears relay-spawned child environments
// and reconstructs proxy variables from this canonical URL.
upsert_env(env, openshell_core::sandbox_env::PROXY_URL, &proxy_url);
for name in [
"ALL_PROXY",
"HTTP_PROXY",
Expand Down Expand Up @@ -9173,10 +9176,14 @@ mod tests {
Some("proxy-pod")
);
// The workload's children still egress through the remote proxy Service.
// Relay-spawned exec processes reconstruct their proxy variables from
// PROXY_URL after clearing the inherited supervisor environment.
let proxy_url = format!("http://{service_dns}:3128");
assert_eq!(
rendered_env(agent, "HTTP_PROXY"),
Some(format!("http://{service_dns}:3128").as_str())
rendered_env(agent, openshell_core::sandbox_env::PROXY_URL),
Some(proxy_url.as_str())
);
assert_eq!(rendered_env(agent, "HTTP_PROXY"), Some(proxy_url.as_str()));
assert_eq!(
rendered_env(agent, "SSL_CERT_FILE"),
Some("/etc/openshell-tls/proxy/ca-bundle.pem")
Expand Down