Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an end-to-end smoke test of the demo stack, required green on the release commit (ROOST practices: E2E for major/minor releases).
e2e-smoke.sh: brings up the compose stack (worker, UI API, Kafka, Druid, MinIO, Postgres; not the UI frontend), renders one event fromexample_data/template.jsonwith text "hello", produces it to Kafka, then asserts over HTTP (POST /events/scanon the UI API) thatContainsHellois true, theBanUserverdict is present, and theUser/meowlabel mutation is present. Waits are bounded polls on readiness/ingestion (no fixed sleeps or retries of the assertions)..github/workflows/e2e.yml: runs onpull_request(path-filtered to app code viadorny/paths-filter, as in Coop'se2e.yaml),release: published, andworkflow_dispatch. Uploadsdocker composelogs as an artifact on failure. Release and manual runs skip the path filter.docs/development/releases.md: new checklist item "E2E Smoke Test workflow is green on the release commit".AGENTS.md: how to run it locally.Negative test (not committed)
Locally changed
example_rules/rules/post_contains_hello.smltophrase='goodbye', restartedosprey-workerandosprey-ui-api, and ranE2E_SKIP_UP=1 ./e2e-smoke.sh. The event was ingested and queryable, but the script failed on theContainsHelloassertion and printed the event's features (noContainsHello, no ban/label). Reverted the rule afterward. Not run on CI.Agent report
mainat0509c5e: no e2e workflow;releases.mdonly required "CI is passing".E2E Smoke Testpassed on the PR branch in ~3 min on a GitHub runner (first CI run; no flakiness observed, but one sample). Also green: Code Quality Checks, Integration Tests, GitHub Actions security analysis (zizmor), Discord Bot. Locally: passed against a stack; negative test failed as expected (see above).pre-commiton changed files passed.release: publishedandworkflow_dispatchtriggers (only thepull_requestpath ran); the failure-log artifact upload (the workflow never failed on CI); the negative test on CI; flakiness over repeated runs; Druid startup time on a slower runner (timeouts are 300s readiness / 180s query). The path filter negative case (a PR touching only docs skips the job) was not exercised.dorny/paths-filterv4.0.3 at the SHA Coop uses, which is a new action for this repo and should be approved. If a ruleset requires specific status checks, addingE2E Smoke Testas required (it is path-filtered, so skipped runs would need handling) is a repo-settings decision, which I did not touch.releases.mdassumes the workflow file namee2e.yml.🤖 Generated with Claude Code