Repository navigation
[COOP-1050] Stream recent decisions from server #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
calebmcquaid
wants to merge
5
commits into
main
Choose a base branch
from
caleb/1050-export
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,391
−380
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b74ac43
feat: stream the full Recent Decisions export from the server
calebmcquaid ff4299a
Re-run CI
calebmcquaid 5823ab9
fix: keep the export page size below the store row cap
calebmcquaid c8d7f79
fix: require VIEW_MRT_DATA and known decision types for the export
calebmcquaid e2a7c6e
docs: add changelog entry for the server-side export
calebmcquaid File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 48 additions & 0 deletions
48
client/src/webpages/dashboard/mrt/activityExportUrl.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { jsonStringify } from '../../../utils/typescript-types'; | ||
| import { exportRangeProblem, toExportDecisions } from './activityExportUrl'; | ||
| import { type DecisionOrAction } from './ManualReviewRecentDecisionsFilter'; | ||
|
|
||
| describe('exportRangeProblem', () => { | ||
| const now = new Date('2026-10-09T12:00:00Z'); | ||
| const tooLong = 'Downloads are limited to 400 days. Narrow the date range.'; | ||
|
|
||
| it.each([ | ||
| [undefined, 'Set a date range to download.'], | ||
| [{}, 'Set a date range to download.'], | ||
| [ | ||
| { | ||
| startDate: new Date('2025-01-01T00:00:00Z'), | ||
| endDate: new Date('2026-02-05T00:00:00Z'), | ||
| }, | ||
| undefined, | ||
| ], | ||
| [ | ||
| { | ||
| startDate: new Date('2025-01-01T00:00:00Z'), | ||
| endDate: new Date('2026-02-06T00:00:00Z'), | ||
| }, | ||
| tooLong, | ||
| ], | ||
| [{ startDate: new Date('2025-09-01T00:00:00Z') }, tooLong], | ||
| ])('%o → %s', (range, expected) => { | ||
| expect(exportRangeProblem(range, now)).toBe(expected); | ||
| }); | ||
| }); | ||
|
|
||
| describe('toExportDecisions', () => { | ||
| it('sends each picked decision as its type, with the action for custom actions', () => { | ||
| const picked: DecisionOrAction[] = [ | ||
| { type: 'IGNORE' }, | ||
| { type: 'AUTOMATIC_CLOSE' }, | ||
| { type: 'CUSTOM_ACTION', actionId: 'act-1' }, | ||
| { type: 'ACCEPT_APPEAL', appealId: 'ap-1', actionIds: [] }, | ||
| ]; | ||
|
|
||
| expect(toExportDecisions(picked.map((it) => jsonStringify(it)))).toEqual([ | ||
| { type: 'IGNORE' }, | ||
| { type: 'AUTOMATIC_CLOSE' }, | ||
| { type: 'CUSTOM_ACTION', actionIds: ['act-1'] }, | ||
| { type: 'ACCEPT_APPEAL' }, | ||
| ]); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: The Download button now navigates to the export URL and never looks at the response. If the server returns a 4xx or 5xx, the user gets no in-page error and no loading state, and the browser's download handling decides what happens. Consider fetching the URL, checking
response.ok, and only then creating the Blob and anchor, with the loading flag restored.Prompt for AI agents