Repository navigation
fix: keep native voice recording through long turns - #715
Merged
Merged
Conversation
rogerchappel
marked this pull request as ready for review
July 20, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
native.recording.long-formdiagnostic after 20 seconds while capture continuesRoot cause
The native VAD completed a recording when either silence reached 1.8 seconds or total recording duration reached 20 seconds. A continuously speaking user was therefore forcibly sent to transcription at roughly 20 seconds, after which the partial transcript was immediately submitted to chat.
User impact
Regular, non-realtime Agent voice can now capture speech beyond 20 seconds and tolerates longer natural pauses before starting the assistant response.
Verification
pnpm test -- src/lib/native-voice-session-generator.test.tspnpm typecheckpnpm exec eslint apps/mobile/scripts/ensure-ios-voice-session.mjs src/lib/native-voice-session-generator.test.tsxcodebuild -project App.xcodeproj -scheme App -sdk iphonesimulator -configuration Debug CODE_SIGNING_ALLOWED=NO buildpnpm buildgit diff --checkRemaining risk
Very long turns are still uploaded as one WAV/STT request. Rolling transcription segments should be implemented separately rather than expanding this focused fix.