Repository navigation
Prevent mobile realtime speaker echo loops - #712
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The browser already requests echo cancellation, noise suppression, and gain control, but CrewCMD currently transports raw PCM through the OpenClaw gateway relay rather than WebRTC. Speaker leakage above the local energy threshold was forwarded upstream before interruption was confirmed, allowing the assistant to hear itself and enter a response loop.
Verification
pnpm test -- src/lib/realtime-voice-gateway-relay.test.ts— 12 tests passedpnpm typecheckgit diff --checkManual QA
On an iPhone without headphones, let a realtime response finish at normal speaker volume and confirm it does not create a new user turn. Then speak clearly over a response for about one second and confirm deliberate barge-in still works.
Risk
Medium. Mobile speaker-mode barge-in is intentionally less eager; desktop behavior is unchanged.