Repository navigation
feat: add focalPoint - #4163
Draft
ted-mundy wants to merge 4 commits into
Draft
feat: add focalPoint#4163ted-mundy wants to merge 4 commits into
focalPoint#4163ted-mundy wants to merge 4 commits into
Conversation
ted-mundy
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2026 16:39 — with
GitHub Actions
Failure
ted-mundy
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2026 16:39 — with
GitHub Actions
Failure
ted-mundy
had a problem deploying
to
CI with Mapbox Tokens
February 27, 2026 16:39 — with
GitHub Actions
Failure
…val, add example Android converts the dp focal point to pixels for GesturesSettings.focalPoint. Both platforms clear the focal point when it's removed from gestureSettings. The doc generator now expands nested object types instead of printing 'signature'.
Contributor
|
Thanks @ted-mundy, this is a nice addition! I pushed a commit on top of yours (your commits are unchanged; I merged
Both SDKs use the focal point for pinch, rotate, double-tap zoom-in and two-finger-tap zoom-out. Verification: the gestures were run away from the marker, then I checked whether the coordinate under the marker moved.
|
Author
|
Am I ok to undraft this @mfazekas ? |
8 tasks done
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
focalPointinto the React Native version of the package. Functionality already exists in both Android and iOS, but no bridge was ever built. This builds that bridge 🙂Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
See the
Map > Gesture Focal Pointexample and the verification notes in the comments.