Skip to content

fix(ios): wait a bit before declaring a view unresolvable - #3962

Merged
mfazekas merged 1 commit into
mainfrom
mfazekas/fix-ios-view-tag-resolve-race
Sep 4, 2025
Merged

mfazekas merged 1 commit into
mainfrom
mfazekas/fix-ios-view-tag-resolve-race

Conversation

@mfazekas

@mfazekas mfazekas commented Sep 4, 2025 •

Copy link
Copy Markdown
Contributor

Fixes race condition in view tag resolver on iOS. After a view component registered we might be trying to look up the viewTag faster than it's registered. We now wait a bit before declaring a view no resolvable.

Description

Fixes #3935 (comment)
Fixes #3836
Closes #3880

To reproduce the issue run Show Region Did Change example. Because it wasn't able to resolve view tags, the callbacks will not work.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Show Region Did Change example
image

Component to reproduce the issue you're fixing

@mfazekas
mfazekas force-pushed the mfazekas/fix-ios-view-tag-resolve-race branch from 1792fcd to 3609478 Compare September 4, 2025 12:52
@mfazekas
mfazekas merged commit 8b37b3f into main Sep 4, 2025
11 checks passed
@mfazekas
mfazekas deleted the mfazekas/fix-ios-view-tag-resolve-race branch September 4, 2025 14:01

This branch was previously deployed

1 inactive deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: onMapIdle and onRegionDidChange events do not work

1 participant