Conversation
`asynctest` is abandoned and doesn't work on Python 3.11 and newer, where it fails to import because `asyncio.coroutine` is gone. That made the whole test suite uncollectable. Everything asynctest provided is in the standard library now: ```py asynctest.TestCase -> unittest.IsolatedAsyncioTestCase asynctest.CoroutineMock -> unittest.mock.AsyncMock asynctest.patch -> unittest.mock.patch async def setUp() -> async def asyncSetUp() ``` The exception is `ClockedTestCase`, which is now in `tests/testutils.py`. Like `asynctest`'s, its clock starts at 0 and only moves when `advance()` says so, so tests never wait for real time to pass. `advance()` steps to each scheduled callback in turn instead of jumping straight to the target time, because a callback that reschedules itself must run once per interval, not once in total. `test_TUI_completion_candidates_for_posargs` was skipped because of an `asynctest` bug and passes now, so it's no longer skipped. The minimum Python version is now 3.10. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asynctestis abandoned and doesn't work on Python 3.11 and newer, where it fails to import becauseasyncio.coroutineis gone. That made the whole test suite uncollectable.Everything asynctest provided is in the standard library now:
The exception is
ClockedTestCase, which is now intests/testutils.py. Like asynctest's, its clock starts at 0 and only moves whenadvance()says so, so tests never wait for real time to pass.advance()steps to each scheduled callback in turn instead of jumping straight to the target time, because a callback that reschedules itself must run once per interval, not once in total.test_TUI_completion_candidates_for_posargswas skipped because of anasynctestbug and passes now, so it's no longer skipped.The minimum Python version is now 3.10.