upgrade status: Strip the prefix (not just legacy ) so a release isn't split across two bars after the rippled -> xrpld rename.#1330
Merged
Conversation
…t split across two bars after the rippled -> xrpld rename.
pdp2121
approved these changes
Jun 30, 2026
Patel-Raj11
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
The Upgrade Status page (
/network/upgrade-status) displayed a single rippled release as two separate bars — e.g.xrpld-3.2.0and3.2.0. This PR normalizes thexrpld-prefix so prefixed and bare version strings aggregate into one bucket.Context of Change
handleNodeVersioncleans the version strings returned by the VHStopology endpoint (
data.xrpl.org/v1/network/topology/nodes/{network}) before they're aggregated. It only stripped therippled-prefix.After rippled was renamed to xrpld, newer peers self-report as
xrpld-3.2.0, which failed thestartsWith('rippled')check and was left untouched — so it never merged with the bare3.2.0values that validators (and VHS) report. Live data confirmed the split:xrpld-3.2.0(221 nodes) and3.2.0(98) appeared as distinct versions, as didrippled-3.1.3(286) vs3.1.3(168).The fix extends the prefix check to also strip
xrpld-. The existing+hashsuffix handling already covers debug builds likexrpld-3.3.0-b0+<hash>.DEBUG. The GitHub stable-release tag is already prefix-free (3.2.0), so no change was needed there.Type of Change
Codebase Modernization
N/A — the touched files are already Hooks + TypeScript.
Before / After
Before:
xrpld-3.2.0and3.2.0(andrippled-3.1.3/3.1.3) rendered as separate bars, fragmenting version-adoption counts.After: Prefixed versions normalize to their bare form (
xrpld-3.2.0→3.2.0), merging with validator/node buckets and the GitHub stable tag into a single accurate bar per release.Test Plan
handleNodeVersionunit test block covering:rippled-andxrpld-prefix stripping, release-suffix preservation (-b7),+hash.DEBUGstripping, and already-clean versions.