Permission Delegation support #1315
Open
cybele-ripple wants to merge 13 commits into
Open
Conversation
kuan121
reviewed
Apr 23, 2026
kuan121
reviewed
Apr 23, 2026
Collaborator
|
Not sure if this is happening in another PR, but IMO the transaction page (maybe also the table detail section) should also show that the tx was sent by a delegate |
- Extract shared CollapsibleSection component used by PermissionDelegation, AccountAsset, and AccountSummary (removes 3 duplicate implementations) - Redesign PermissionDelegation as a card layout (address + permission chips) instead of a full-width table - Drop the always-"Active" Status column and unused EmptyMessageTableRow branch - Remove unused in-branch translation keys (permission_delegation column/ status/no_delegations, assets_available, other_data, not_available, percent_of_supply, currency_toggle_help)
CI fails to resolve react-router-dom from the new test file. Use MemoryRouter from react-router (the pattern used by QuickHarness) to avoid the resolution issue.
- Reorder padding/gap in delegate-item to satisfy stylelint - Wait for rendered state (not just mock call) in the empty and card-structure tests to avoid CI timing failures - Re-prettier AccountAsset styles.scss
Restore assets_available, other_data, not_available, percent_of_supply, and currency_toggle_help at their original positions. These were added earlier in this branch and should be preserved even if not yet wired up.
kuan121
reviewed
Apr 27, 2026
Updates the PermissionDelegation mock to return a testid element and adds a getByTestId assertion alongside the other child-component checks in the 'renders static parts' test.
Contributor
Author
Created an issue for this new feature |
kuan121
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR includes a permission delegation section in the account account page.
Context of Change
The new permission delegation section appears between account properties and assets held in the account page. If the account does not have any permission delegations associated with it, then the section will now appear
Type of Change
Codebase Modernization
Before / After
Example of the account page before any permission delegations (or if the account does not have any permission delegations associated with it):
Screenshots for both desktop and mobile after the permission delegation changes are made:
Test Plan
There are tests that cover this change: