fix(charset_filter): Incorrect condition for checking the namespace - #1218
Merged
Conversation
ksqsf
force-pushed
the
fix-charset-filter-ns-check
branch
from
August 23, 2026 15:06
d28e565 to
8ee193d
Compare
There was a problem hiding this comment.
Pull request overview
Fixes incorrect namespace handling in charset_filter.
Changes:
- Recognizes the default
filternamespace. - Suppresses unsupported-parameter logging for the default namespace.
- Preserves filtering behavior when extended charset is disabled.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ksqsf
force-pushed
the
fix-charset-filter-ns-check
branch
from
August 23, 2026 15:09
8ee193d to
704f304
Compare
ksqsf
force-pushed
the
fix-charset-filter-ns-check
branch
from
August 23, 2026 15:09
704f304 to
3676500
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1217