Skip to content

Code optimization and fix share social media from Recordings and roomRecordings#866

Closed
CherifAmine wants to merge 1 commit into
riadvice:developfrom
CherifAmine:originbbbeasy/codeOptimization_shareLink
Closed

Code optimization and fix share social media from Recordings and roomRecordings#866
CherifAmine wants to merge 1 commit into
riadvice:developfrom
CherifAmine:originbbbeasy/codeOptimization_shareLink

Conversation

@CherifAmine

Copy link
Copy Markdown
Contributor

Description

  • Fix display style recordings Card from roomRecordings.
  • Fix share social media from Recordings and rooms Recordings.
  • Fix Replay button.
  • Code optimization.

Changes Made

Create a new component for Modal Social Links to avoid rewriting the same code.

Closes Issue(s)

Related Issue(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

image image image image

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
15.2% 15.2% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@CherifAmine CherifAmine closed this Aug 7, 2023
@CherifAmine

Copy link
Copy Markdown
Contributor Author

replaced by : #867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant