ocp4_workload_openshift_virtualization: fix common boot image import on HCO 4.22 / OCP 5.0 - #182
Merged
Merged
Conversation
…mport via top-level spec field The boot_sources_snapshot=false path (external ODF/Ceph) re-enables common boot image import by patching the deprecated .spec.featureGates.enableCommonBootImageImport. On HCO 4.22 (OpenShift 5.0) that field is a no-op — the setting was promoted to the top-level .spec.enableCommonBootImageImport — so import silently stays off and no golden images are imported. The role's own HyperConverged template already writes the top-level field, so this aligns the re-enable patch with the template and works on both 4.21 and 4.22+. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
juliaaano
requested review from
agonzalezrh,
fridim,
rut31337,
stencell and
wkulhanek
as code owners
September 22, 2026 15:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When
ocp4_workload_openshift_virtualization_boot_sources_snapshot: false(the path used on external-ODF/Ceph clusters), the role re-enables common boot image import by patching.spec.featureGates.enableCommonBootImageImport: true. This changes that final patch — and the matching comment — to the top-level.spec.enableCommonBootImageImport: true.Why
On HCO 4.22 (OpenShift 5.0) the
enableCommonBootImageImportsetting was promoted from.spec.featureGatesto the top-level.spec. Writing the deprecatedfeatureGatessub-field is a silent no-op there, so the "re-enable" step never takes effect and the HyperConverged is left with common boot image import disabled — no golden-image DataSources (RHEL/Fedora/CentOS) are imported.Observed on a live OCP 5.0 (HCO
v4.22.9) deploy: after the role ran,.spec.enableCommonBootImageImportwas unset and noDataImportCrons existed until the flag was manually toggled in the console. On OCP 4.21 (HCOv4.21) the oldfeatureGatespath still works, so the regression only appears on 4.22+.The role's HyperConverged template already writes the top-level field (
.spec.enableCommonBootImageImport), so this makes the re-enable patch consistent with the template. The top-level field exists on 4.21 as well, so the change is backward compatible.🤖 Generated with Claude Code