Repository navigation
Match Fullstory provisioning and session hosts by domain wildcard - #65
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Session ingestion rejected staging URLs even for accounts provisioned with the staging Subtext endpoint. Replace exact hostname allowlists with wildcard matching for *.fullstory.com in both Subtext provisioning and session ingestion, so future regions and environments do not require hostname-specific releases.
Subtext URLs still require HTTPS and the exact /mcp/subtext path, with no credentials, custom port, query, or fragment. Session URLs retain HTTPS, credential, and session-path validation. Lookalike domains and the bare fullstory.com domain remain rejected. Update API discovery and setup/architecture documentation to describe this behavior.
Regression tests cover staging and future/nested environment hosts, registration without capture artifacts, fragment normalization, retry deduplication, unsafe/unsupported URL rejection, and staging callbacks using the saved endpoint. The staging tests reproduced invalid_session before the fix.
Validation: all 124 tests pass with
npm test;npm run buildpasses.Companion QA wildcard change: https://github.com/replayio/loop-qa/pull/6647. QA's initial staging-only fix was merged in #6646. No migration or capture package release is needed.