Repository navigation
Centralize service access and forward account settings to QA - #46
Open
bhackett1024 wants to merge 6 commits into
Open
bhackett1024 wants to merge 6 commits into
bhackett1024 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account data-service configuration now belongs to QA's main account database. Self Healing exposes authenticated settings management and centralizes service access without retaining a second configuration store.
GET/PUT /api/v1/account/data-config, forwarding to QA with the authenticated account's dedicated QA token. Include requested zero-retention policy, database access, artifact endpoints and recording endpoints; validate redacted status responses.QAClientand sharedAccountServiceResolverfor connection, dashboard, pipeline and deployment reviewer operations. QA configuration failures fail closed; external policy blocks unsupported work with 501. Deployment reviewer upgrades skip explicitly unsupported external accounts.Companion QA PR: https://github.com/replayio/loop-qa/pull/5334. Deploy its configuration API, main-database migration and per-environment encryption secret before this change. No new Self Healing secret or migration is needed. An older QA deployment without the endpoint fails closed.
This prepares the interfaces and configuration ownership; it does not establish ZDR, activate external QA work, or stop/migrate existing jobs. Remaining account-work routing and provider adapters are documented.
The account-work admission policy is now shared by normal account service resolution and authenticated session callbacks. Callbacks derive the account from the authenticated stored session and recheck QA settings before decrypting Subtext credentials or contacting the provider. Existing callback URLs therefore cannot bypass newly saved external policy. QA remains the settings authority; there is no additional configuration store here.
Validation: 26 focused account, connection and configuration tests passed, including callback policy rejection before provider access and credential binding to the session owner. Build passed. Final-head CI (
ce59986) was cancelled before executing any steps: GitHub reports “The job was not acquired by Runner of type hosted even after multiple attempts.” Validation remains incomplete due to this infrastructure blocker. No production migration or deployment was performed.Artifact configuration now forwards standard S3 endpoint/region/bucket/addressing/prefix/credentials settings to QA, matching the companion PR. No local storage adapter or additional secret persistence is introduced. Validation for this schema alignment: all 133 tests and the build pass.