Skip to content

Centralize service access and forward account settings to QA - #46

Open
bhackett1024 wants to merge 6 commits into
mainfrom
codex/account-service-interfaces
Open

bhackett1024 wants to merge 6 commits into
mainfrom
codex/account-service-interfaces

Conversation

@bhackett1024

@bhackett1024 bhackett1024 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Account data-service configuration now belongs to QA's main account database. Self Healing exposes authenticated settings management and centralizes service access without retaining a second configuration store.

  • Add GET/PUT /api/v1/account/data-config, forwarding to QA with the authenticated account's dedicated QA token. Include requested zero-retention policy, database access, artifact endpoints and recording endpoints; validate redacted status responses.
  • Introduce a named QAClient and shared AccountServiceResolver for connection, dashboard, pipeline and deployment reviewer operations. QA configuration failures fail closed; external policy blocks unsupported work with 501. Deployment reviewer upgrades skip explicitly unsupported external accounts.
  • Remove the proposed local configuration table/migration. QA owns encrypted persistence, atomic revision checks, and trusted decrypted reads. Self Healing neither caches these secrets nor serves settings to QA workers.

Companion QA PR: https://github.com/replayio/loop-qa/pull/5334. Deploy its configuration API, main-database migration and per-environment encryption secret before this change. No new Self Healing secret or migration is needed. An older QA deployment without the endpoint fails closed.

This prepares the interfaces and configuration ownership; it does not establish ZDR, activate external QA work, or stop/migrate existing jobs. Remaining account-work routing and provider adapters are documented.

The account-work admission policy is now shared by normal account service resolution and authenticated session callbacks. Callbacks derive the account from the authenticated stored session and recheck QA settings before decrypting Subtext credentials or contacting the provider. Existing callback URLs therefore cannot bypass newly saved external policy. QA remains the settings authority; there is no additional configuration store here.

Validation: 26 focused account, connection and configuration tests passed, including callback policy rejection before provider access and credential binding to the session owner. Build passed. Final-head CI (ce59986) was cancelled before executing any steps: GitHub reports “The job was not acquired by Runner of type hosted even after multiple attempts.” Validation remains incomplete due to this infrastructure blocker. No production migration or deployment was performed.

Artifact configuration now forwards standard S3 endpoint/region/bucket/addressing/prefix/credentials settings to QA, matching the companion PR. No local storage adapter or additional secret persistence is introduced. Validation for this schema alignment: all 133 tests and the build pass.

@bhackett1024 bhackett1024 changed the title Add account data-service configuration and centralize service access Centralize service access and forward account settings to QA Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant