Skip to content

Fix toolbar colors in dark mode#234

Open
carlosabadia wants to merge 2 commits into
mainfrom
carlos/fix-dark-mode-toolbar
Open

Fix toolbar colors in dark mode#234
carlosabadia wants to merge 2 commits into
mainfrom
carlos/fix-dark-mode-toolbar

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown

Greptile Summary

This PR updates the toolbar colors used by charts in dark mode. The main changes are:

  • Scheme-aware modebar active and focus colors in the shared chrome stylesheet.
  • A new --chart-modebar-focus public token for toolbar keyboard focus rings.
  • Updated docs and API spec text for the modebar token defaults.
  • Regression tests for dark active toolbar styling and docs-app palette overrides.

Confidence Score: 5/5

Safe to merge with minimal risk.

The changes are narrowly scoped to CSS token fallbacks, docs, and tests. The updated active and focus behavior is covered by browser and static token tests. No correctness or security issues were found in the changed paths.

No files require special attention.

T-Rex T-Rex Logs

What T-Rex did

  • I compared the pre-PR modebar behavior to the PR version to confirm the color calculations for the active button are changing as expected.
  • I verified the PR behavior shows updated colors including activeBackground, barBackground, and focusShadow in the post-PR capture.
  • I ran the targeted pytest test suite and confirmed it passed with 1 passed in 3.83s and an exit code of 0.
  • I linked and reviewed the artifacts (two videos, two posters, and the pytest log) to support the verification.

View all artifacts

T-Rex Ran code and verified through T-Rex

Important Files Changed

Filename Overview
js/src/20_theme.ts Adjusts modebar dark palette defaults, active-button background token usage, and a dedicated modebar focus token.
tests/test_ui_issue_regressions.py Adds a browser regression test for dark active modebar styling and custom modebar focus/active overrides.
docs/styling/themes-and-tokens.md Updates public token documentation for scheme-aware toolbar active and focus colors.
spec/api/styling.md Aligns the styling API spec with the new modebar active and focus token behavior.
docs/app/tests/test_docs_site.py Adds a regression assertion that the docs app no longer overrides built-in modebar palette tokens.
tests/test_static_client_security.py Extends static CSS-token coverage to include --chart-modebar-focus.

Reviews (1): Last reviewed commit: "update" | Re-trigger Greptile

@codspeed-hq

codspeed-hq Bot commented Jul 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 102 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing carlos/fix-dark-mode-toolbar (3c3b90f) with main (b6ab496)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant