Skip to content

fix(rueidiscompat): set IsCacheHit for cached IntCmd and DurationCmd results #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rueian merged 1 commit into from
Oct 16, 2026
Merged

fix(rueidiscompat): set IsCacheHit for cached IntCmd and DurationCmd results #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rueidiscompat/command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ func (cmd *IntCmd) from(res rueidis.RedisResult) {
val, err := res.AsInt64()
cmd.SetErr(err)
cmd.SetVal(val)
cmd.setIsCacheHit(res.IsCacheHit())
}

func newIntCmd(res rueidis.RedisResult) *IntCmd {
Expand All @@ -501,6 +502,7 @@ func (cmd *DurationCmd) from(res rueidis.RedisResult) {
cmd.SetErr(err)
if val > 0 {
cmd.SetVal(time.Duration(val) * cmd.precision)
cmd.setIsCacheHit(res.IsCacheHit())
return
}
cmd.SetVal(time.Duration(val))
Expand Down Expand Up @@ -549,6 +551,7 @@ func (cmd *SliceCmd) from(res rueidis.RedisResult) {
vals[i] = arr
}
cmd.SetVal(vals)
cmd.setIsCacheHit(res.IsCacheHit())
return
}
for i, v := range arr {
Expand Down
19 changes: 19 additions & 0 deletions rueidiscompat/command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1895,3 +1895,22 @@ func TestACLLogCmd(t *testing.T) {
}
})
}

func TestCacheHitFromCachedResult(t *testing.T) {
cached := func(m rueidis.RedisMessage) rueidis.RedisResult {
var hit rueidis.RedisMessage
if err := hit.CacheUnmarshalView(m.CacheMarshal(nil)); err != nil {
t.Fatal(err)
}
return mock.Result(hit)
}
if !newIntCmd(cached(mock.RedisInt64(2))).IsCacheHit() {
t.Error("IntCmd: expected IsCacheHit to be true")
}
if !newDurationCmd(cached(mock.RedisInt64(60)), time.Second).IsCacheHit() {
t.Error("DurationCmd: expected IsCacheHit to be true")
}
if !newSliceCmd(cached(mock.RedisArray(mock.RedisArray(mock.RedisString("a")))), true).IsCacheHit() {
t.Error("SliceCmd (JSONObjKeys): expected IsCacheHit to be true")
}
}
Loading