Skip to content

Fix for MAX_JOBS: unbound variable error when asking for script help - #141

Merged
hinriksnaer merged 1 commit into
redhat-et:mainfrom
cmagina:max-jobs-fix
Jun 23, 2026
Merged

hinriksnaer merged 1 commit into
redhat-et:mainfrom
cmagina:max-jobs-fix

Conversation

@cmagina

@cmagina cmagina commented Jun 22, 2026 •

Copy link
Copy Markdown
Collaborator

Hit a bug due not moving the MAX_JOBS variable to the DEFAULT_ENV_OPTS in the usage printout

Summary by CodeRabbit

  • Documentation
    • Updated the help text for the -j MAX_JOBS option to display the correct default value, improving clarity when users review available command-line options.

Signed-off-by: Craig Magina <cmagina@redhat.com>
@cmagina
cmagina requested a review from hinriksnaer June 22, 2026 19:01
@cmagina cmagina self-assigned this Jun 22, 2026
@coderabbitai

coderabbitai Bot commented Jun 22, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: f7a1903d-ecce-4de3-b176-682b69ae23d2

📥 Commits

Reviewing files that changed from the base of the PR and between 7e053cd and 99c1cd7.

📒 Files selected for processing (1)
  • triton-dev-containers.sh

📝 Walkthrough

Walkthrough

In triton-dev-containers.sh, the usage() help text for the -j MAX_JOBS option is updated to display the default value from DEFAULT_ENV_OPTS["MAX_JOBS"] instead of $MAX_JOBS. No runtime logic or option handling is changed.

Changes

Usage Text Fix

Layer / File(s) Summary
usage() help string for -j MAX_JOBS
triton-dev-containers.sh
The default value shown in the -j MAX_JOBS help line is sourced from DEFAULT_ENV_OPTS["MAX_JOBS"] instead of $MAX_JOBS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: fixing an unbound variable error for MAX_JOBS in the script help output.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hinriksnaer
hinriksnaer merged commit 3d7ad84 into redhat-et:main Jun 23, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants