Skip to content

Fix for passing wrong environment variable for USERNAME - #140

Merged
hinriksnaer merged 1 commit into
redhat-et:mainfrom
cmagina:username-fix
Jun 3, 2026
Merged

hinriksnaer merged 1 commit into
redhat-et:mainfrom
cmagina:username-fix

Conversation

@cmagina

@cmagina cmagina commented Jun 3, 2026 •

Copy link
Copy Markdown
Collaborator

Found a bug where the triton-dev-containers.sh script was setting USER instead of USERNAME variable while all of the scripts were expecting USERNAME.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected environment variable naming consistency in development containers to ensure proper alignment throughout the container environment setup.

Signed-off-by: Craig Magina <cmagina@redhat.com>
@cmagina
cmagina requested a review from hinriksnaer June 3, 2026 20:42
@cmagina cmagina self-assigned this Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9ed1ec22-b8e3-4ede-b7f4-3911ecaf2a56

📥 Commits

Reviewing files that changed from the base of the PR and between 0adb9c7 and 4e5fbde.

📒 Files selected for processing (1)
  • triton-dev-containers.sh

📝 Walkthrough

Walkthrough

The script updates environment variable naming by changing the exported container environment key from USER to USERNAME in two locations: the default environment options map and the user arguments export function. This aligns the external container environment variable name with the script's internal USERNAME variable usage.

Changes

Environment Variable Naming Consolidation

Layer / File(s) Summary
USERNAME environment variable consolidation
triton-dev-containers.sh
Default environment options and user arguments export are updated to use USERNAME instead of USER as the container environment variable key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: fixing the incorrect passing of the USER environment variable and correcting it to use USERNAME instead.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hinriksnaer
hinriksnaer merged commit 7e053cd into redhat-et:main Jun 3, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants