Skip to content

Fixing minor commands and dead code removal - #138

Merged
hinriksnaer merged 1 commit into
mainfrom
cleanup/dead-code-removal
May 9, 2026
Merged

hinriksnaer merged 1 commit into
mainfrom
cleanup/dead-code-removal

Conversation

@hinriksnaer

@hinriksnaer hinriksnaer commented May 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores

    • Removed deprecated Make targets for triton image builds and container execution
    • Removed deprecated gosu image references
    • Updated linting configuration
  • Documentation

    • Clarified devsetup script behavior in README
  • Configuration

    • Changed default CentOS version from 10 to 9 for container builds

@coderabbitai

coderabbitai Bot commented May 9, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 440b0730-5ed9-4481-8580-a689ac953c17

📥 Commits

Reviewing files that changed from the base of the PR and between 3d382c4 and 5b901e3.

📒 Files selected for processing (8)
  • .devcontainer/devcontainer.md
  • .github/workflows/cpu-image.yml
  • .github/workflows/cuda-image.yml
  • .github/workflows/rocm-image.yml
  • .yamllint.yml
  • Makefile
  • README.md
  • dockerfiles/Dockerfile
💤 Files with no reviewable changes (5)
  • .yamllint.yml
  • .github/workflows/cuda-image.yml
  • .github/workflows/cpu-image.yml
  • .github/workflows/rocm-image.yml
  • Makefile

📝 Walkthrough

Walkthrough

The PR removes deprecated build targets and gosu image references from the Makefile, eliminates USERNAME=triton build arguments from Docker image workflows, updates the default CentOS version from 10 to 9, removes ignored paths from yamllint configuration, and updates development setup documentation and README references.

Changes

Build System and Configuration Cleanup

Layer / File(s) Summary
Makefile Build Targets
Makefile
Removed GOSU_IMAGE_NAME, GOSU_IMAGE_TAG variables; deleted deprecated .PHONY declarations and targets for triton-image, triton-cpu-image, triton-amd-image, triton-run, and triton-amd-run.
CI Docker Workflows
.github/workflows/cpu-image.yml, .github/workflows/cuda-image.yml, .github/workflows/rocm-image.yml
Removed USERNAME=triton build argument from build-args blocks in CPU, CUDA, and ROCM image build jobs.
Dockerfile Configuration
dockerfiles/Dockerfile
Updated ARG CENTOS_VERSION default from 10 to 9.
Linting Configuration
.yamllint.yml
Removed ignore: section that excluded builddir/* and .clang-format from linting checks.
Development and Documentation
.devcontainer/devcontainer.md, README.md
Updated devcontainer setup command from make devcontainers to make -C .devcontainer generate; updated README to reference devinstall_<framework> scripts instead of devsetup_<framework>.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: removing deprecated Make targets/variables and fixing the devcontainer command, plus other cleanup work.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cleanup/dead-code-removal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@hinriksnaer
hinriksnaer merged commit ef0f7f5 into main May 9, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant