Skip to content

fix: set correct vllm commit flag - #137

Merged
hinriksnaer merged 2 commits into
mainfrom
fix-vllm-commit
May 9, 2026
Merged

hinriksnaer merged 2 commits into
mainfrom
fix-vllm-commit

Conversation

@hinriksnaer

@hinriksnaer hinriksnaer commented May 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated development installation scripts with improved environment variable handling for package repository configuration
    • Enhanced wheel installation process to support custom package source specifications via new environment variable options
    • Refined environment variable preservation during development setup for better flexibility

@coderabbitai

coderabbitai Bot commented May 9, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@hinriksnaer has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 7 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 7d86cb44-e7e4-493d-8b69-db5b9b723fc6

📥 Commits

Reviewing files that changed from the base of the PR and between df18548 and c0e60eb.

📒 Files selected for processing (1)
  • scripts/devinstall_vllm.sh
📝 Walkthrough

Walkthrough

The pull request updates environment variable conventions in development installation scripts. It renames VLLM_COMMIT to PIP_VLLM_COMMIT across multiple scripts and adds support for a new PIP_VLLM_EXTRA_INDEX_URL override variable to control PyPI wheel installation indexing behavior.

Changes

Pip Wheel Installation Configuration

Layer / File(s) Summary
Environment Variable Preservation
scripts/devsetup.sh
SAVE_VARS list updated: VLLM_COMMIT removed, PIP_VLLM_COMMIT added to control which variables are passed through run_as_user.
Wheel Installation Logic
scripts/devinstall_vllm.sh
install_whl function now checks PIP_VLLM_EXTRA_INDEX_URL and applies it as --extra-index-url for PyPI installs; similarly uses PIP_VLLM_COMMIT to construct extra index URLs when set.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: set correct vllm commit flag' accurately reflects the main change: updating environment variable handling from VLLM_COMMIT to PIP_VLLM_COMMIT across installation scripts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-vllm-commit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
scripts/devinstall_vllm.sh (1)

155-166: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

nightly currently overrides explicit PIP_VLLM_EXTRA_INDEX_URL from env.

PIP_VLLM_EXTRA_INDEX_URL is set unconditionally in nightly, so callers cannot actually override the index for nightly installs.

Suggested fix
 case "$pip_build" in
 release) ;;
 nightly)
-    PIP_VLLM_EXTRA_INDEX_URL="${pip_vllm_index_url_base}/nightly"
+    PIP_VLLM_EXTRA_INDEX_URL="${PIP_VLLM_EXTRA_INDEX_URL:-${pip_vllm_index_url_base}/nightly}"
     ;;
 esac
As per coding guidelines, "**Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.**"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@scripts/devinstall_vllm.sh` around lines 155 - 166, The nightly branch
unconditionally overwrites PIP_VLLM_EXTRA_INDEX_URL so callers cannot override
it; in the case for pip_build == "nightly" change the assignment to only set
PIP_VLLM_EXTRA_INDEX_URL when it is empty (e.g., check [ -z
"${PIP_VLLM_EXTRA_INDEX_URL:-}" ] before assigning using
pip_vllm_index_url_base/nightly) so explicit environment values are preserved;
update the case block around pip_build and ensure later logic that uses
PIP_VLLM_EXTRA_INDEX_URL (the pip_install_args population) continues to work
unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@scripts/devinstall_vllm.sh`:
- Around line 155-166: The nightly branch unconditionally overwrites
PIP_VLLM_EXTRA_INDEX_URL so callers cannot override it; in the case for
pip_build == "nightly" change the assignment to only set
PIP_VLLM_EXTRA_INDEX_URL when it is empty (e.g., check [ -z
"${PIP_VLLM_EXTRA_INDEX_URL:-}" ] before assigning using
pip_vllm_index_url_base/nightly) so explicit environment values are preserved;
update the case block around pip_build and ensure later logic that uses
PIP_VLLM_EXTRA_INDEX_URL (the pip_install_args population) continues to work
unchanged.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9db5063a-7fc2-4ad3-a3c1-938835e19928

📥 Commits

Reviewing files that changed from the base of the PR and between 442ea47 and df18548.

📒 Files selected for processing (2)
  • scripts/devinstall_vllm.sh
  • scripts/devsetup.sh

@hinriksnaer
hinriksnaer merged commit 3d382c4 into main May 9, 2026
10 checks passed
@hinriksnaer
hinriksnaer deleted the fix-vllm-commit branch May 9, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant