Repository navigation
fix: set correct vllm commit flag - #137
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates environment variable conventions in development installation scripts. It renames ChangesPip Wheel Installation Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/devinstall_vllm.sh (1)
155-166:⚠️ Potential issue | 🟠 Major | ⚡ Quick win
nightlycurrently overrides explicitPIP_VLLM_EXTRA_INDEX_URLfrom env.
PIP_VLLM_EXTRA_INDEX_URLis set unconditionally innightly, so callers cannot actually override the index for nightly installs.As per coding guidelines, "**Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.**"Suggested fix
case "$pip_build" in release) ;; nightly) - PIP_VLLM_EXTRA_INDEX_URL="${pip_vllm_index_url_base}/nightly" + PIP_VLLM_EXTRA_INDEX_URL="${PIP_VLLM_EXTRA_INDEX_URL:-${pip_vllm_index_url_base}/nightly}" ;; esac🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/devinstall_vllm.sh` around lines 155 - 166, The nightly branch unconditionally overwrites PIP_VLLM_EXTRA_INDEX_URL so callers cannot override it; in the case for pip_build == "nightly" change the assignment to only set PIP_VLLM_EXTRA_INDEX_URL when it is empty (e.g., check [ -z "${PIP_VLLM_EXTRA_INDEX_URL:-}" ] before assigning using pip_vllm_index_url_base/nightly) so explicit environment values are preserved; update the case block around pip_build and ensure later logic that uses PIP_VLLM_EXTRA_INDEX_URL (the pip_install_args population) continues to work unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@scripts/devinstall_vllm.sh`:
- Around line 155-166: The nightly branch unconditionally overwrites
PIP_VLLM_EXTRA_INDEX_URL so callers cannot override it; in the case for
pip_build == "nightly" change the assignment to only set
PIP_VLLM_EXTRA_INDEX_URL when it is empty (e.g., check [ -z
"${PIP_VLLM_EXTRA_INDEX_URL:-}" ] before assigning using
pip_vllm_index_url_base/nightly) so explicit environment values are preserved;
update the case block around pip_build and ensure later logic that uses
PIP_VLLM_EXTRA_INDEX_URL (the pip_install_args population) continues to work
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: 9db5063a-7fc2-4ad3-a3c1-938835e19928
📒 Files selected for processing (2)
scripts/devinstall_vllm.shscripts/devsetup.sh
Summary by CodeRabbit
Release Notes