Add CI workflow config and fix lint issues - #60
Conversation
Add .github/workflows/ci.yaml matching the bare template (with node-version 22.20.0, since this template uses vite 8 / rolldown which require node >=22.12.0). package.json: add test:types and test:unit scripts, remove the duplicate type-check script (point deploy at test:types), bump engines.node to >=22.12.0, and downgrade typescript 7.0.2 -> 6.0.3 so it satisfies the typescript-eslint peer range. src/client/main.ts: fix pre-existing lint errors so the lint step passes: mark the floating loadGame() promise with void, comment out the dead aspect-ratio computation (kept as a reference snippet) along with the startingAspect field/assignment, and grandfather existing no-explicit-any usages with eslint-disable-next-line so the rule keeps blocking new any usage. Built with Snoocode
There was a problem hiding this comment.
this patterns seems questionable but i recognize fixing it is out of scope for this PR.
|
|
||
| this.canvasElement.style.height = '100%'; //`${newHeight}px`; | ||
| this.canvasElement.style.width = '100%'; //`${newWidth}px`; | ||
| // Example: compute dimensions that preserve the game's starting aspect |
There was a problem hiding this comment.
do we need this for GameMaker to function properly?
There was a problem hiding this comment.
No, this code was doing nothing, and the linter was mad about it.
I kept it as an example with the assumption that we needed this code for something, maybe for LLMs or users to get a basic understanding of how they can interact with the canvas
Will double-check in slack
| }, | ||
| "engines": { | ||
| "node": ">=22.2.0" | ||
| "node": ">=22.12.0" |
There was a problem hiding this comment.
i didn't follow why the version of Node is incremented but differs in some of the templates. can we unify these?
There was a problem hiding this comment.
A bump was needed to satisfy vite requirements. Bare doesn't use vite so it stayed untouched
I'll bump the versions everywhere in a separate series of PR, and then we'll bump it to 24 sometime soon
2 participants
Add .github/workflows/ci.yaml matching the bare template (with node-version 22.20.0, since this template uses vite 8 / rolldown which require node >=22.12.0).
package.json: add test:types and test:unit scripts, remove the duplicate type-check script (point deploy at test:types), bump engines.node to >=22.12.0, and downgrade typescript 7.0.2 -> 6.0.3 so it satisfies the typescript-eslint peer range.
src/client/main.ts: fix pre-existing lint errors so the lint step passes: mark the floating loadGame() promise with void, remove the dead aspect-ratio computation (whose result was already unused) and the now-unused startingAspect field, and grandfather existing no-explicit-any usages with eslint-disable-next-line so the rule keeps blocking new any usage.
💸 TL;DR
📜 Details
Design Doc
Jira
🧪 Testing Steps / Validation
✅ Checks