Repository navigation
[DeadCode] Skip RemoveAlwaysTrueIfConditionRector on PHP + HTML files - #8895
Closed
TomasVotruba wants to merge 1 commit into
Closed
TomasVotruba wants to merge 1 commit into
TomasVotruba wants to merge 1 commit into
Conversation
Unwrapping an always-true if in a file with inline HTML drops the close-tag transition and prints invalid PHP. Reuse the file-level containsHTML() guard, matching the former HTMLAverseRectorInterface behavior.
TomasVotruba
force-pushed
the
tv-skip-inline-html-always-true-if
branch
from
October 30, 2026 13:00
79ff8a6 to
82f11ab
Compare
TomasVotruba
changed the title
Member
|
it seems already covered at PR: Let's closing 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an always-true
iflives in a file that mixes PHP and inline HTML, unwrapping its statements drops the close-tag transition and prints invalid PHP - the inline HTML ends up emitted inside PHP mode.was rewritten to the broken:
<?php <div>always</div>Reuse the file-level
containsHTML()guard, matching the formerHTMLAverseRectorInterfacebehavior. Added a skip fixture.