Repository navigation
Add importPartiallyQualifiedNames argument to withImportNames() to keep names like Field\TextField - #8884
Open
ker0x wants to merge 1 commit into
Open
Add importPartiallyQualifiedNames argument to withImportNames() to keep names like Field\TextField#8884ker0x wants to merge 1 commit into
ker0x wants to merge 1 commit into
Conversation
…ep names like Field\TextField Closes rectorphp/rector#9941
samsonasik
reviewed
Oct 29, 2026
| $rectorConfig->removeUnusedImports(false); | ||
|
|
||
| $rectorConfig->importShortClasses(); | ||
| $rectorConfig->importPartiallyQualifiedNames(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes rectorphp/rector#9941
As suggested in the issue, this adds a new
withImportNames()argument to keep partially qualified names (an imported namespace plus a short name) as written, instead of skippingNameImportingPostRectorper path:Field\TextField) or relative (namespace\Sub\Foo) in the source stays as written, even when the class is also imported directly. This is decided from the parser'soriginalNameattribute.\App\Foo) and names that rules create are still imported.@var Source\Query\Parameterand@Source\Mapping\Column(...)are kept, while@\App\Mapping\Column(...)is still imported.true, so existing behaviour is unchanged. The argument is added last, so positional calls keep working.RectorConfig::importPartiallyQualifiedNames()is added for closure configs.Tests are in
tests/Issues/KeepPartiallyQualifiedNames. All theskip_*fixtures fail when the argument is enabled, so each one tests it.