Repository navigation
Move union dedup and array printing to type mappers - #8858
Merged
TomasVotruba merged 1 commit intoOct 27, 2026
Merged
Conversation
samsonasik
approved these changes
Oct 27, 2026
Member
|
Thanks, good improvement 👌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BracketsAwareUnionTypeNode::__toString()andSpacingAwareArrayTypeNode::__toString()changed the meaning of the type when it was printed. They removed duplicate union members, changed(A|B)[]toA[]|B[]orarray<int, A<X>|A<Y>>, and changedarray<string, (A|B)[]>toarray<string, array<A|B>>.This PR moves these rules to
UnionTypeMapperandArrayTypeMapper. The mappers now create the final node tree.__toString()prints the nodes as they are. This is necessary to use the format-preserving printer of phpstan/phpdoc-parser, which prints the node tree and does not call__toString().ArrayTypeMapperchanges an array of union item type to a union of arrays, or toarray<int, ...>when all items are generics of the same type.UnionTypeMappermerges nested unions and removes duplicates.HAS_GENERIC_TYPE_PARENTattribute is removed.Types that Rector creates do not change. When Rector reprints a type from the original docblock, it keeps duplicate union members (
int|intstaysint|int), and(A|B)[][]is printed correctly. Before, it was printed as(A[]|B)[][].More PRs coming after this one ;) They will remove a lot of code and make things faster.