shortcode: Add py.md as alternative to cutt.ly#3001
Conversation
There was a problem hiding this comment.
The code and motivation are both good, but this option opens up vulnerabilities in the code system. For example what if someone maliciously registers a short code for a popular repository with py.md?
I think the best option is to have a different prefix for py.md links, or something to visibly distinguish them from known short codes. Different users should not get different repositories with the same short code.
|
i can add all known repos to my account if thats okey so users can access every repo without any problem. |
|
I like the idea of "!", which we can easily migrate away from in the future if we decide to remove cutt.ly. However, creating all short codes leaves your account as another single point of failure. I recommend that you instead communicate with fellow repository maintainers to let them create their own short codes before I merge this. |
fire-light42
left a comment
There was a problem hiding this comment.
Code looks good, idea is good, just want some feedback from other developers.
cutt.ly is currently blocked in Turkiye, so users are getting connection errors when trying to load repos with shortcodes. I wrapped the request in a try-catch and added py.md as a fallback. Now if cutt.ly fails, it just tries py.md instead.