Ignore unowned(unsafe) captures by default - #6824
Merged
Merged
Conversation
Yurii201811
marked this pull request as ready for review
July 13, 2026 08:45
Generated by 🚫 Danger |
SimplyDanny
requested changes
Jul 29, 2026
SimplyDanny
left a comment
SimplyDanny
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @Yurii201811 for taking this!
|
|
||
| private extension UnownedVariableCaptureRule { | ||
| final class Visitor: ViolationsSyntaxVisitor<ConfigurationType> { | ||
| override func visitPost(_ node: TokenSyntax) { |
Collaborator
There was a problem hiding this comment.
Let's have a visitPost(_ node: ClosureCaptureSpecifierSyntax) instead which allows us to check for specifier and detail directly.
| @ConfigurationElement(key: "severity") | ||
| private(set) var severityConfiguration = SeverityConfiguration<Parent>(.warning) | ||
| @ConfigurationElement(key: "include_unsafe") | ||
| private(set) var includeUnsafe = false |
Collaborator
There was a problem hiding this comment.
Let's call it allow_explicit_unsafe_unowned. It should be false by default to match the current behavior. It should be opt-in.
SimplyDanny
approved these changes
Jul 31, 2026
SimplyDanny
enabled auto-merge (squash)
July 31, 2026 11:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ignore
unowned(unsafe)captures by default while preserving an opt-ininclude_unsafesetting.Background
The explicit unsafe spelling communicates the intended lifetime tradeoff.
Closes #6817
Changes
include_unsafe, defaulting tofalseunownedandunowned(safe)Verification